Add VHD_MAX and QCOW2_MAX symbolic size constants - #500
Merged
Conversation
This was referenced Apr 24, 2026
glehmann
force-pushed
the
gln/block-device-enhancement-and-lun-deduplication-rqtm
branch
from
April 24, 2026 20:35
1168197 to
f101a3f
Compare
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
3 times, most recently
from
April 29, 2026 17:38
a6948a5 to
0a82603
Compare
glehmann
force-pushed
the
gln/block-device-enhancement-and-lun-deduplication-rqtm
branch
from
April 29, 2026 17:38
f101a3f to
ede9108
Compare
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
from
May 11, 2026 15:48
0a82603 to
b73bcc9
Compare
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
2 times, most recently
from
May 12, 2026 13:23
5df0dc2 to
ff50780
Compare
glehmann
force-pushed
the
gln/block-device-enhancement-and-lun-deduplication-rqtm
branch
from
May 12, 2026 13:23
1960a93 to
8f39146
Compare
Millefeuille42
approved these changes
May 12, 2026
Lankou66
approved these changes
May 12, 2026
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
2 times, most recently
from
May 13, 2026 13:58
c70e171 to
fbb8227
Compare
glehmann
force-pushed
the
gln/block-device-enhancement-and-lun-deduplication-rqtm
branch
2 times, most recently
from
May 18, 2026 16:22
9f88dc5 to
7cc39d2
Compare
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
from
May 18, 2026 16:22
fbb8227 to
3e8fe23
Compare
stormi
approved these changes
May 18, 2026
rzr
approved these changes
May 19, 2026
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
from
May 19, 2026 15:29
3e8fe23 to
44d95e4
Compare
glehmann
force-pushed
the
gln/block-device-enhancement-and-lun-deduplication-rqtm
branch
2 times, most recently
from
May 19, 2026 15:55
3845b8f to
8b8e409
Compare
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
from
May 19, 2026 15:55
44d95e4 to
c097695
Compare
glehmann
force-pushed
the
gln/block-device-enhancement-and-lun-deduplication-rqtm
branch
from
May 20, 2026 19:02
8b8e409 to
88a80e1
Compare
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
from
May 20, 2026 19:02
c097695 to
937fa6d
Compare
glehmann
force-pushed
the
gln/block-device-enhancement-and-lun-deduplication-rqtm
branch
from
May 21, 2026 13:43
88a80e1 to
ce5225e
Compare
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
from
May 21, 2026 13:43
937fa6d to
27533d0
Compare
glehmann
force-pushed
the
gln/block-device-enhancement-and-lun-deduplication-rqtm
branch
from
May 21, 2026 14:07
ce5225e to
e196d05
Compare
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
2 times, most recently
from
May 21, 2026 14:16
2a7ce58 to
4ca7988
Compare
glehmann
force-pushed
the
gln/block-device-enhancement-and-lun-deduplication-rqtm
branch
from
May 21, 2026 14:16
e196d05 to
291e27e
Compare
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
from
May 21, 2026 14:29
4ca7988 to
ce36044
Compare
glehmann
force-pushed
the
gln/block-device-enhancement-and-lun-deduplication-rqtm
branch
from
May 22, 2026 15:29
1130de5 to
dc44617
Compare
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
from
May 22, 2026 15:29
ce36044 to
ff961ea
Compare
Allow passing VHD_MAX and QCOW2_MAX as values to --volume-size and --write-volume-cap, making it easy to test at the maximum supported VDI size for each image format. MAX_VDI_SIZE in storage.py is now derived from the same constants to keep a single source of truth. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/add-max-volume-size-constants-npxp
branch
from
May 29, 2026 11:37
ff961ea to
b882ed3
Compare
Base automatically changed from
gln/block-device-enhancement-and-lun-deduplication-rqtm
to
master
May 29, 2026 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing VHD_MAX and QCOW2_MAX as values to --volume-size and
--write-volume-cap, making it easy to test at the maximum supported VDI
size for each image format. MAX_VDI_SIZE in storage.py is now derived
from the same constants to keep a single source of truth.
Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech
This PR is part of a tree containing 19 PRs:
mastermaster